경북대 FE_이정민_3주차 과제 Step2 #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 9, 2024 20:21
sjoleee
approved these changes
Jul 14, 2024
| import { keyframes } from '@emotion/react'; | ||
| import styled from '@emotion/styled'; | ||
|
|
||
| const Loading: React.FC = () => { |
There was a problem hiding this comment.
여기서는 왜 React.FC를 사용하셨나요?
React.FC를 쓸때와 쓰지 않을때의 차이는 무엇인가요?
Comment on lines
+38
to
+40
| isError: boolean; | ||
| errorCode?: string; | ||
| errorMessage?: string; |
There was a problem hiding this comment.
error?: { code?: string; message?: string }error와 관련된 것들을 모아서 하나의 객체로 처리하면 어떨까요?
Comment on lines
+12
to
+16
| if (axios.isAxiosError(error)) { // axios는 자동으로 JSON 변환해줌 | ||
| const code = error.response?.status?.toString() || 'UNKNOWN_ERROR'; | ||
| const description = error.response?.data?.description || '알 수 없는 오류가 발생했어요.'; | ||
| throw Object.assign(new Error(), {code, description }); | ||
| } |
There was a problem hiding this comment.
굳이 이렇게 만들어주는 이유가 있을까요?
에러 객체에서 필요한 정보가 코드와 설명 이외에도 있으면 어떻게 대응하실 예정일까요?
| const response = await fetchData('/api/v1/ranking/products', filters); | ||
| setFetchState({ isLoading: false, isError: false, data: response.products }); | ||
| } catch (error) { | ||
| const axiosError = error as AxiosError; |
There was a problem hiding this comment.
타입 단언이 좋은 선택일까요?
굳이 타입 단언을 하지 않고도 axiosError일때 아래 로직을 수행할 수 있을 것 같아요~
Comment on lines
+82
to
+90
| {fetchState.isLoading ? ( | ||
| <Loading /> | ||
| ) : fetchState.isError ? ( | ||
| <ErrorMessage code= {fetchState.errorCode} message={fetchState.errorMessage || '데이터를 불러오는 중에 문제가 발생했습니다.'} /> | ||
| ) : fetchState.data && fetchState.data.length > 0 ? ( | ||
| <GoodsRankingList goodsList={fetchState.data} /> | ||
| ) : ( | ||
| <EmptyData /> | ||
| )} |
There was a problem hiding this comment.
삼항연산자를 중첩 사용하여 가독성이 좋지 않은 것 같아요. 조금 더 깔끔하게 표현해볼 수 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님,
"Error, Loading Status 핸들링 하기"를 구현한 2단계 코드를 제출합니다!
감사합니다 :)